Email or username:

Password:

Forgot your password?
dansup's posts Post Back to profile
dansup

Received an interesting bug report regarding the Pixelfed photo filters in the webUI.

The JS logic we employ can be abused for privacy reasons, and this user is using a browser that mitigates this, leading to long waits.

I know Pixelfed like the back of my hand, so that's why I asked which browser they are using, and of course, that is the real cause behind this issue!

#wontFix

Jakob Why does it take SO long to apply a filter in webfrontend? (edited) I waited for more than a minute on the task "applying filter" dansup -Jakob Why does it take SO long to apply a filter in webfrontend?... What browser are you using? • johanempa joined the room Jakob Vanadium from GrapheneOS dansup • Jakob Vanadium from GrapheneOS Aha, thats why. Apparently, the methods we use to apply a filter can be abused for privacy reasons, but don't worry, most people use Chrome or Firefox and the filter gets applied instantly!
20 October at 8:43 | Open on mastodon.social
9 comments
Philipp :geeko: :natenom:

@dansup Not sure that I like your stance on that. "The JS logic we employ can be abused for privacy reasons" pretty much means there is a security bug in your JS code, and if that's true, Vanadium is one of few browsers that mitigate it. WontFix pretty much sounds as if user safety isn't a concern for #Pixelfed then?

20 October at 8:51 | Open on digitalcourage.social
dansup

@derfopps If you look at the actual code, you will see we simply create a canvas object and apply the filter to it.

While the canvas browser API can be abused in various ways, the only way to prevent that would be to eliminate the feature all together!

github.com/pixelfed/pixelfed/b

20 October at 9:21 | Open on mastodon.social
Jonas Geiler

@dansup What kind of code are you using for filtering that it gets mitigated by the browser 🤔

20 October at 8:58 | Open on fosstodon.org
dansup
Jonas Geiler

@dansup Thanks! I landed at the exact same code block a few minutes ago 😅 I should have checked before writing a comment

20 October at 9:23 | Open on fosstodon.org
infinite love ⴳ
dansup

@trwnh yeah, I mean don't worry in the context of our usage!

We simply create a svg object and use that to apply the filter

github.com/pixelfed/pixelfed/b

You are reading too much into this, we're on the same team 🤠

20 October at 11:24 | Open on mastodon.social
Oblomov

@dansup @trwnh if it's just an SVG object maybe you can do it without canvas? As in: create an actual SVG by its textual representation?

20 October at 11:49 | Open on sociale.network
Thomas Touhey

@dansup You could probably display a pop-up if applying the filter takes more than 5 or 10 seconds, with text like:

> It seems that applying the filter takes longer than expected. Your browser may be limiting access to this API for privacy reasons. <Learn more...>

20 October at 11:23 | Open on social.touhey.org
Go Up