Email or username:

Password:

Forgot your password?
Adam Johnson :django: :python:

Be sure to check your kid's candy this year! I found an unreviewable gigantic PR.

candy bar cross-section showing GitHub PR change count: +144,394 lines, -97,981 lines
34 comments
SnoopJ

@adamchainz @FunkyBob what monster would put drive-by PEP8 into candy :blobfoxdizzy:

Moshe Zadka

@SnoopJ @adamchainz @FunkyBob

Eh, that's not scary.

Verify that you get bit-for-bit same results from running "black" on the before. If not, reject. If yes, accept.

Funky Bob

@moshez @SnoopJ @adamchainz You can run black on my codebase when it stops making it harder to read, and not a day before! :P

Moshe Zadka

@FunkyBob @SnoopJ @adamchainz

Simple algorithm: "no black in CI? don't contribute to project".

chjara
@adamchainz editor converted all the newlines
Moshe Zadka

@adamchainz If you take another bite, you see the commit message. "Refactored to use modern practices."

ftl ✅✅

@adamchainz hey how did they get access to my company GitHub. Security breach

stfn :raspberrypi: :python:

@adamchainz I once submitted such a PR, I was a junior dev and got a task to install and run black on the whole codebase.

James Corey

@adamchainz My god, what kind of sick psychopath would.... oh. Nevermind!

Go Up