Email or username:

Password:

Forgot your password?
All posts (λ.'s posts Post Back to profile
Top-level
Niels Abildgaard

@borkdude This is what PRs are for, though, right? They enable line-by-line discussion of changes, too

3 Dec 2022 at 18:41 | Wall-to-wall | Open on mas.to
7 comments
(λ. borkdude)

@nielsa I didn't actually wanted to commit the code. Just save it for reference.

3 Dec 2022 at 18:52 | Open on mastodon.social
Niels Abildgaard
(λ. borkdude)
Niels Abildgaard

@borkdude If what you have isn't ready to merge, a draft PR seems fitting.

If irrelevant CI runs on draft PRs that seems more like a CI config problem?

Even if CI runs, I genuinely don't understand wanting to send a patch file. The collaboration experience is so much worse, doesn't support mobile devices, etc.

4 Dec 2022 at 8:39 | Open on mas.to
(λ. borkdude)

@nielsa It was never my intent to merge this patch. I just wanted to save it as an idea. It's not what I usually do, but this time it seemed like the best option. I usually delete stale branches, etc. But an attachment in an issue I would never delete.

4 Dec 2022 at 8:48 | Open on mastodon.social
Niels Abildgaard

@borkdude hmm I guess I don't really recognize the situation. You never see your code changes becoming something that may be merged? Then why save them?

4 Dec 2022 at 9:15 | Open on mas.to
(λ. borkdude)

@nielsa Just as a note of something that I tried but didn't yield the performance benefit I suspected :) I guess I could also commit the patch into a notes folder or so. I want to keep it just as a reference of what I tried

4 Dec 2022 at 10:58 | Open on mastodon.social
Go Up