Email or username:

Password:

Forgot your password?
Top-level
Andy

So far:
* License was probably not lawyered, so it contradicts itself a lot, even though they probably meant "redistributions need to drop all branding and attachment to Winamp" which is fair
* The license violates GitHub terms of service, because the ToS grant the right to fork for every public repository
* The source includes commercial or non-distributable libraries
* SHOUTcast server side code is included in the repo (lol???)
* Published all codesigning utilities (and certs + pws, yikes)

28 comments
Jyrki :jyrki:🐾:heart_nb:

@pixel like, come on now. there aren't even aarch64 binaries out there for it, so i had to fix it myself

Doridian

@nilsding Oh dear. It just keeps getting funnier.

Boyd Stephen Smith Jr.

@nilsding github.com/WinampDesktop/winam to go to the "removed" directory directly, instead of having to navigate through the diff.

I wonder when this will finally get removed by Github... probably never if someone keeps a private fork around that includes this commit.

Jyrki :jyrki:🐾:heart_nb:

@BoydStephenSmithJr haven’t you read the license? forking is not allowed! 🚫

I think the first link in the issue I created still works fine too

Andy

Funniest bit:

"Forking is not allowed" vs. "Contributions encouraged"

On GitHub, that requires a fork however πŸ€”

or do they want us to use git send-email?

Andy

Our friends at Winamp do not seem to know git that much, do they?

Lection, the effectiveness of a "Remove closed source code" commit:

github.com/WinampDesktop/winam

Andy

Jef is hard at work trying to remove the SHOUTcast code from the repository

after merging it back in again...

github.com/WinampDesktop/winam

Simon

@pixel Oh dear... I really hope they're at least *considering* taking the entire thing offline while they're working out all the licensing kinks.

mkj

@lunacb Now that's evidence of a high-quality review process if I ever saw it!

@pixel

stefan
@pixel :comfypopcorn: The issues just keep getting better. It seems like they also have some Dolby stuff in there, like proprietary stuff.... Oh boy.
Andy

Winamp, it really whips the authority of their executables.

They accidentally pushed all codesigning stuff, including signature passwords into the repo as well :blobcatnotlikethis:

github.com/WinampDesktop/winam

Ongion

@pixel wow, this has just been a catastrophe

Andy

Actually, I am highly doubting *accidental* at this point, but the poor employee who just remembered that Winamp wanted to release their code today just went and slapped EVERYTHING into git.

I'm a bit in a rollercoaster of emotions of thinking this is catastrophic and catastrophically hilarious.

Sora5084

@pixel Wow... that's wild... especially Winamp's License and all the closed source code... :blobcatsweat:
*grabs a clone while it's still online* 755 MB... :blobcateyes:
*goes searching for the blobs*

Damien

@pixel send patch files on a mailing list like in ye olden days

Leeloo

@pixel
Github uses "fork" in a different way than basically anyone else.

For example, fork doesn't even exist in git terminology, a github "fork" most closely corresponds to a git repository.

cassie

@pixel I think this is a terminology problem, when they say forking they must mean a separately maintained version, not a github fork.

Andy

@porglezomp it most likely is, but that's what is written in their license.

As mentioned above, probably nothing a software/publishing lawyer looked over.

Go Up