Gregory's ServerAlways be the first one to review your own PR's! While it has some strong "I'll read that email I just sent from the sent folder to see it from their perspective" vibes, I've lost count on the number of times where I've spotted some obvious mistakes that I never caught while working on the code, or compiled the commits into a PR.
 4 comments
@willbeason Agreed! I guess the logical conclusion is to start printing out PRs too :P  As a non-author reviewer, a PR that already has a bunch of the author’s comments and updates* before I even begin my review makes me happy. *As long as they’ve not simply because the submitter opened the PR before the work was really done. Unfortunately, in my experience, this is more common than one might assume. And, is especially common in “agile” environments where everyone is just trying to close their issues before the end of the sprint/iteration so they don’t carry-over. The very best include comments that help to describe the high level change(s) as a road map for reviewers. |
@anderseknert What's nice about reviewing the PR in a change control tool rather than in your IDE is it forces you to read your code in a different way than you wrote it. Similar to how printing out a document makes it easier to find typos.