Email or username:

Password:

Forgot your password?
Top-level
Jonathan Frederickson

@0leil @jwildeboer Per-commit review is a point that I hadn't considered. With GitHub's PR UI only making the end result of all commits together apparent, I could see someone introducing a security vulnerability in a commit, fixing it in another, and then tricking a packager into publishing the version with the vuln...

1 comment
ManicDee

@jfred @0leil @jwildeboer per-commit doesn’t make sense when you are just going to deliver all those commits in one PR, same effect as squashing commits when accepting the PR.

Main issue I see is trying to do too much in one PR.

Go Up