|
Top-level
The chart widget is the most complex widget I’ve ever written, coming in at roughly 4000 lines of code. Turns out that combining rendering for large and small screens, CSS styling, dark mode, high contrast mode, an entirely visual layout of data, accessibility requirements for the visually impaired, RTL *and* a date-based time axis makes things quite complex. Dates especially. There are going to be bugs in it. 4 comments
@bugaevc 👀 It kind of skirts round that by having various parts of the chart have a fixed minimum size, so it kind of has a fixed size request (except it doesn’t; it distributes additional width appropriately).  @pwithnall I noticed you've marked constructors of the various widgets as returning (transfer full). Is this an oversight or intentional? @bugaevc I guess you mean they should be (transfer floating). If so, probably an oversight. But review comments go on GitLab rather than on Mastodon pls ;) |
Gregory's Server
@pwithnall but does it do whf/hfw measurements in a consistent way 🙃