Email or username:

Password:

Forgot your password?
Hayden Stainsby

Happy new clippy lints breaking your CI day everyone!

#rust #rustlang #clippy

8 comments
Predrag Gruevski

@hds this is why I recommend a once-a-month job that compiles + runs clippy on your project using beta Rust.

If it triggers new lints and fails, you have an entire month to fix it before it breaks your PR's CI flow 🦀

Hayden Stainsby

@predrag at work we just pin the rust version and update it with a job. If the update job fails we fix in the same change and submit together.

Hayden Stainsby

@predrag but we should probably run against beta as well occasionally.

Artёm

@hds More like, Happy I'm too lazy to run locally a linter after updating the #rustlang version day.

Hayden Stainsby

@krom but isn’t not running it locally what makes it break in CI?

Ed Page

@hds I pin rustc for my lint checks and have RenovateBot auto-merge the update if nothing was broken.

Hayden Stainsby

@epage yeah. We do the same thing at work, which is the CI thing that breaks (not mainline). I want to adapt it to try running with `—fix` and then updating the change, but haven’t got there yet.

But then there are some OSS projects I contribute to that just pull the latest version in on PR checks. I’ve found out about a Rust update in minutes after the release more than once because of that. Should probably try to convince someone to go the pinned rust route there too.

Ed Page

@hds If people need an example of this, see github.com/epage/_rust

That is the template for all my projects.

Go Up