Email or username:

Password:

Forgot your password?
Paul Cantrell

Who called it “code review” instead of “objection-oriented programming”

17 comments
Paul Cantrell

(The serious answer to this frivolous question is of course “somebody on a good team where code review was supposed to be constructive dialogue and not just endless nitpicking“)

Steve Randy Waldman

@inthehands perhaps you should include a period before that last quote.

Sami Juvonen

@inthehands Is this the same team that has Agile standups not devolve into droning rounds of status reports?

Paul Cantrell

@sjuvonen
The same! And they don’t snub people for tool choices either.

Michael Wyman

@inthehands the ease or difficulty of code review depends greatly on the outlook of the team: both the reviewers and the reviewed. I’ve seen review greatly improve code and everybody learns things, I’ve seen bad reviewers turn people off the process entirely, and I’ve seen reviews become endless fights when the code author comes in thinking “this is a massive waste of time, my code doesn’t need it.”

Lucien Dupont

@inthehands So tired of nit picking code reviews.. makes me want to find a new job.

Óscar Morales Vivó

@inthehands joke’s on you I’ve been programming in Objection-C for years.

Paul Cantrell

@MyLittleMetroid
Ah, yes, the language known for the dynamic modification of dispatch tables known as “method kibitzing”

Jon

@inthehands how dare you start a line with the ‘{ ‘?

Paul Cantrell

@jongary
You need to add a test for this reply

Vertigo #$FF

@inthehands @jongary Sigh.

Still waiting for the +3 so I can finally land this damn feature before the code freeze, can I PLEASE get someone to review this?

Jon

@vertigo @inthehands Been there. A few times it took weeks.

Air Adam

@inthehands Same person who came up with "linter" when "complainer" feels like a more accurate accessory to the compiler!

Paul Cantrell

@airadam
Ha, going to use this one, for real

enoch_exe_inc

@inthehands That’s excellent! I’m calling it that instead right away.

Go Up